Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop reporting traces after the worker process begins to exit #105

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

wangrzneu
Copy link
Contributor

The reporting task can slow down the worker process exiting if many traces are generated or the reporting rate slows down. In my case, the reporting task will slow down the reloading process, after the config or Lua code is updated.

@wu-sheng wu-sheng added this to the 1.0.0 milestone Jul 6, 2022
@wu-sheng wu-sheng added the enhancement New feature or request label Jul 6, 2022
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit d15c0ce into apache:master Jul 6, 2022
@wangrzneu wangrzneu deleted the check-exiting branch July 6, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants