Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated tag key from http.status to http.status_code #107

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

wuwen5
Copy link
Contributor

@wuwen5 wuwen5 commented Aug 13, 2024

Updated tag key from http.status to http.status_code to ensure consistency with searchableTracesTags.

@wu-sheng wu-sheng added this to the 1.0.0 milestone Aug 13, 2024
@wu-sheng wu-sheng added the bug Something isn't working label Aug 13, 2024
@wu-sheng
Copy link
Member

Note, we don't have release manager for this agent for now.

@wu-sheng
Copy link
Member

Please refer to the main repo, e2e tool should be updated.

@wu-sheng
Copy link
Member

And CI VM env should be updated too. Otherwise, CI wouldn't run.

Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are interested in joining us as a release manager, let me know.
I noticed you have made several commits in different repositories.

@wu-sheng wu-sheng merged commit 5b107c4 into apache:master Aug 14, 2024
2 checks passed
@wuwen5
Copy link
Contributor Author

wuwen5 commented Aug 15, 2024

If you are interested in joining us as a release manager, let me know. I noticed you have made several commits in different repositories.

@wu-sheng Thank you for considering me for the release manager role. I'm indeed interested in joining the team and contributing my skills. Let me know what the next steps are.

@wu-sheng
Copy link
Member

Ping me on slack. I could work with you to try for release.

@wuwen5 wuwen5 changed the title Updated tag key from 'http.status' to 'http.status_code' Updated tag key from http.status to http.status_code Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants