Write release doc for RM. #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
commented
Aug 18, 2024
wu-sheng
commented
Aug 18, 2024
wankai123
approved these changes
Aug 18, 2024
|
I tested this, and have this out on the luarocks. https://luarocks.org/modules/apache-skywalking/skywalking-nginx-lua/1.0.0-0 |
wuwen5
reviewed
Aug 19, 2024
| ```shell | ||
| > export RELEASE_VERSION=x.y.z | ||
|
|
||
| > tar czf skywalking-nginx-lua-${RELEASE_VERSION}-src.tgz \ |
There was a problem hiding this comment.
There is already a release.md file, Do we recommend using make release-src here ?
There was a problem hiding this comment.
Oops, I missed that. I am going to merge these two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wuwen5 Could you review this doc?
The doc was missed, and I barely put them together.