fix: allow timer to restart #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix should be fine. But I want to confirm what is the case that restarts the timer? |
wu-sheng
approved these changes
Sep 24, 2024
nic-6443
approved these changes
Sep 24, 2024
During skywalking plugin reload in APISIX, timer restart case can be observed. |
|
When will this new version v1.1.0 be released? |
|
I don't have plan to do so. Maybe you could ask people from api7? You have committer to initial patch release(1.0.1) if you want. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The APISIX skywalking plugin reload creates a scenario where
destroyBackendTimer()is called:https://github.com/apache/apisix/blob/a478de8a586671bc7dd0dcf89d8db18d9913ab7c/apisix/plugins/skywalking.lua#L154
but after successful reload. When
startBackendTimer()is called:https://github.com/apache/apisix/blob/a478de8a586671bc7dd0dcf89d8db18d9913ab7c/apisix/plugins/skywalking.lua#L144
it won't succeed because
self.stoppedstill remainstrue.This issue has been fixed.