Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IgnoreSuffix feature #93

Merged
merged 12 commits into from
Jan 13, 2022
Merged

Add IgnoreSuffix feature #93

merged 12 commits into from
Jan 13, 2022

Conversation

alonelaval
Copy link
Member

No description provided.

@wu-sheng wu-sheng added this to the 0.7.0 milestone Jan 10, 2022
@wu-sheng wu-sheng added the enhancement New feature or request label Jan 10, 2022
wu-sheng
wu-sheng reviewed Jan 11, 2022
View reviewed changes
lib/skywalking/util.lua Outdated Show resolved Hide resolved
wu-sheng
wu-sheng reviewed Jan 11, 2022
View reviewed changes
lib/skywalking/util.lua Outdated Show resolved Hide resolved
dmsolr
dmsolr reviewed Jan 11, 2022
View reviewed changes
lib/skywalking/tracer.lua Outdated Show resolved Hide resolved
wu-sheng
wu-sheng reviewed Jan 11, 2022
View reviewed changes
lib/skywalking/util.lua Outdated Show resolved Hide resolved
@wu-sheng
Copy link
Member

@alonelaval CI fails

https://github.com/apache/skywalking-nginx-lua/runs/4773611968?check_suite_focus=true

@alonelaval
Copy link
Member Author

https://github.com/apache/skywalking-nginx-lua/runs/4773611968?check_suite_focus=true

OK，I will fix.

@tzssangglass
Copy link
Member

hi, @alonelaval the CI installation of OpenResty includes luajit, try to use /usr/local/openresty-debug/luajit/bin/luajit instead of lua to test, ffi is a module of luajit.

@alonelaval
Copy link
Member Author

hi, @alonelaval the CI installation of OpenResty includes luajit, try to use /usr/local/openresty-debug/luajit/bin/luajit instead of lua to test, ffi is a module of luajit.

no work，in my local why luarocks installed package 'luaunit' not found.

@wu-sheng wu-sheng mentioned this pull request Jan 13, 2022
Merged
wu-sheng
wu-sheng reviewed Jan 13, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
wu-sheng
wu-sheng reviewed Jan 13, 2022
View reviewed changes
examples/nginx.conf Outdated Show resolved Hide resolved
wu-sheng
wu-sheng reviewed Jan 13, 2022
View reviewed changes
examples/nginx.conf Outdated Show resolved Hide resolved
@wu-sheng wu-sheng requested a review from dmsolr January 13, 2022 07:59
@wu-sheng
Copy link
Member

@membphis @dmsolr @tzssangglass Could you review the PR again?

membphis
membphis approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wu-sheng
wu-sheng approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for more approval.

wu-sheng
wu-sheng reviewed Jan 13, 2022
View reviewed changes
licenses/LICENSE-luaffi.txt Outdated
@@ -0,0 +1,58 @@
BSD License

For luaffifb software
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thing, why do we have this update? I think we don't copy the luaffi source codes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@wu-sheng wu-sheng merged commit 49adb5f into apache:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsolr dmsolr dmsolr approved these changes

@membphis membphis membphis approved these changes

@wu-sheng wu-sheng wu-sheng approved these changes

@moonming moonming Awaiting requested review from moonming

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@alonelaval @wu-sheng @tzssangglass @membphis @dmsolr