feat: support update the peer before requesting outgoing #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
reviewed
Feb 18, 2022
wu-sheng
reviewed
Feb 23, 2022
wu-sheng
reviewed
Feb 23, 2022
wu-sheng
reviewed
Feb 23, 2022
wu-sheng
reviewed
Feb 23, 2022
|
Once you pass this, please remove these component IDs, instance topology is available since this. |
wu-sheng
reviewed
Feb 24, 2022
wu-sheng
reviewed
Feb 24, 2022
wu-sheng
reviewed
Feb 25, 2022
|
Please add |
wu-sheng
reviewed
Feb 25, 2022
wu-sheng
reviewed
Feb 25, 2022
| @@ -131,7 +131,8 @@ The following APIs are for developers or using this lib out of the Nginx case. | |||
| ## Nginx APIs | |||
| - **startTimer**, `require("skywalking.client"):startBackendTimer("http://127.0.0.1:8080")`. Start the backend timer. This timer register the metadata and report traces to the backend. | |||
| - **destroyBackendTimer**, `require("skywalking.client"):destroyBackendTimer()`. Stop the timer created by `startBackendTimer`, and clean unreported data. | |||
| - **start**, `require("skywalking.tracer"):start("upstream service", correlation)`. Begin the tracing before the upstream begin. The custom data (table type) can be injected as the second parameter, and then they will be propagated to the downstream service. | |||
| - **start**, `require("skywalking.tracer"):start("upstream service", correlation)`. Begin the tracing before the upstream beginning. The custom data (table type) can be injected as the second parameter, and then they will be propagated to the downstream service. If `upstream service` could be determined precisely later, keep it as `nil` and call `inject` method when peer(upstream address) is resolved by load balancer and DNS resolver. | |||
There was a problem hiding this comment.
@dmsolr I added the last sentence for the document, please recheck.
wu-sheng
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.