Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat add sw_grpc plugin #362

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Feat add sw_grpc plugin #362

merged 2 commits into from
Nov 18, 2024

Conversation

tsonglew
Copy link
Contributor

Add sw_grpc plugin

  • If adding a new plugin, add a component id in the main repo: grpc already exists
  • If adding a new plugin, add a logo in the UI repo: grpc already exists
  • I have added the library to pyproject.toml (plugin group) by running poetry add library --group plugins
  • I have rebuilt the Plugins.md documentation by running make doc-gen

@tsonglew tsonglew changed the title feat: add sw_grpc plugin Feat add sw_grpc plugin Nov 16, 2024
@wu-sheng wu-sheng added feature New feature plugin Plugin labels Nov 16, 2024
@wu-sheng wu-sheng added this to the 1.2.0 milestone Nov 16, 2024
@wu-sheng
Copy link
Member

Please fix CI.

wu-sheng
wu-sheng reviewed Nov 18, 2024
View reviewed changes
skywalking/config.py Outdated Show resolved Hide resolved
@tsonglew @wu-sheng
Update Configuration.md
699b80f 
Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
kezhenxu94
kezhenxu94 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please also add Python language to the main repo https://github.com/apache/skywalking/blob/7e6061a918017929733e77725982947854fb6ca9/oap-server/server-core/src/test/resources/component-libraries.yml#L114

@kezhenxu94 kezhenxu94 merged commit 320ef70 into apache:master Nov 18, 2024
62 checks passed
@tsonglew tsonglew mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng left review comments

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@Superskyyy Superskyyy Awaiting requested review from Superskyyy

Assignees
No one assigned
Labels
feature New feature plugin Plugin
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tsonglew @wu-sheng @kezhenxu94