Fix styles and tests.

apache · Nov 6, 2023 · 679c86d · 679c86d
1 parent 3281863
commit 679c86d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/...er/server-core/src/test/java/org/apache/skywalking/oap/server/core/MockModuleManager.java b/...er/server-core/src/test/java/org/apache/skywalking/oap/server/core/MockModuleManager.java
@@ -28,6 +28,7 @@ public abstract class MockModuleManager extends ModuleManager {
     private final Map<String, ModuleProviderHolder> moduleProviderHolderMap = Maps.newHashMap();
 
     public MockModuleManager() {
+        super("Mock");
         init();
     }
 

diff --git a/...ry-module/src/main/java/org/apache/skywalking/oap/server/library/module/ModuleDefine.java b/...ry-module/src/main/java/org/apache/skywalking/oap/server/library/module/ModuleDefine.java
@@ -23,7 +23,6 @@
 import java.util.Enumeration;
 import java.util.Properties;
 import java.util.ServiceLoader;
-import org.apache.logging.log4j.core.util.Loader;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

diff --git a/...dule/src/test/java/org/apache/skywalking/oap/server/library/module/ModuleManagerTest.java b/...dule/src/test/java/org/apache/skywalking/oap/server/library/module/ModuleManagerTest.java
@@ -33,7 +33,7 @@ public void testInit() throws ServiceNotProvidedException, ModuleNotFoundExcepti
         configuration.addModule("BaseA").addProviderConfiguration("P-A", new Properties());
         configuration.addModule("BaseB").addProviderConfiguration("P-B", new Properties());
 
-        ModuleManager manager = new ModuleManager();
+        ModuleManager manager = new ModuleManager("Test");
         manager.init(configuration);
 
         BaseModuleA.ServiceABusiness1 serviceABusiness1 = manager.find("BaseA")
@@ -52,7 +52,7 @@ public void testModuleConfigInit() throws ModuleConfigException, ModuleNotFoundE
         settings.put("attr4", true);
         configuration.addModule("BaseA").addProviderConfiguration("P-A", settings);
 
-        ModuleManager manager = new ModuleManager();
+        ModuleManager manager = new ModuleManager("Test");
         manager.init(configuration);
 
         final ModuleServiceHolder provider = manager.find("BaseA").provider();
@@ -72,7 +72,7 @@ public void testModuleMissing() {
             configuration.addModule("BaseA").addProviderConfiguration("P-A", new Properties());
             configuration.addModule("BaseB").addProviderConfiguration("P-B2", new Properties());
 
-            ModuleManager manager = new ModuleManager();
+            ModuleManager manager = new ModuleManager("Test");
             manager.init(configuration);
         });
     }
@@ -84,7 +84,7 @@ public void testCycleDependency() {
             configuration.addModule("BaseA").addProviderConfiguration("P-A2", new Properties());
             configuration.addModule("BaseB").addProviderConfiguration("P-B3", new Properties());
 
-            ModuleManager manager = new ModuleManager();
+            ModuleManager manager = new ModuleManager("Test");
             manager.init(configuration);
         });
     }
-Original file line number
+Diff line change
@@ Expand Up @@
         private final Map<String, ModuleProviderHolder> moduleProviderHolderMap = Maps.newHashMap();
         public MockModuleManager() {
+            super("Mock");
             init();
         }
@@ Expand Down @@