-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSPP] PHP E2E #11330
[OSPP] PHP E2E #11330
Conversation
@simonluo345 Could you provide some description? |
added COPY entrypoint.sh /entrypoint.sh
@heyanlong From the OSPP perspective, I have concerns about why most commits are made by you rather than a student. |
I appreciate your input and value your feedback. I understand your concern about the commits. We are primarily focusing on debugging and resolving any issues that may have arisen during the development process. This involves some code changes to ensure that the project functions correctly. My mentor has been actively involved in this phase to guide and assist me in addressing these issues. My mentor has been involved in the commits, and this project has provided me with valuable learning experiences. I've been closely working with my mentor to understand the debugging process. |
This PR only includes 100-200 LOCs, it is hard to say it is involved in too many codes. Anyway, this is a reminder. And as a liaison between the org and ospp committee, I have the responsibility to oversight all task execution, and feedback. |
Thank you for pointing out this. I really appreciate it. |
Isn't php case added into the GHA control file? |
Sir could you clarify this? I don't really understand what you mean. |
Never mind. I noticed you updated the PHP case. |
Remove the WIP prefix if this is ready. |
- key: http.method | ||
value: {{ notEmpty .value }} | ||
- key: http.status_code | ||
value: {{ notEmpty .value }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe here can be a specific value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are predictable, we should lock the value. This assertion is only about having value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi sir, after I locked the value and ran the local test, the e2e testing was not going to pass because the order of the testing was wrong. I think it is a bug from the e2e testing tool. Can I change it back to {{notEmpty .value}} instead of a fixed value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kezhenxu94 Any suggestion here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simonluo345 consider pushing your changes so that I can see where is the potential problem, one thing I noticed from the screenshot is that you might wrote some of the expected rules twice like this
Not sure though, would be helpful to push the changes here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simonluo345 Your reply doesn't make sense. We are asking whether your expected data is correct.
Making tests passed is not the purpose. Write the tests correctly and really verify codes, these are the purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wu-sheng Thank you for pointing out this. I misunderstood the question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kezhenxu94 just pushed the changes, could you please take a look?
You need to resolve the conflicts, the CI could run after that. |
hi sir, the conflicts are resolved. |
This pull request introduces changes and improvements to the PHP Docker setup and configuration for SkyWalking agent integration:
Docker Setup:
Updated to PHP 8.1-fpm-bullseye base image.
Introduced a builder stage to streamline the build process.
Installed Rust and its dependencies, a prerequisite for SkyWalking agent build.
Cloned and set the SkyWalking PHP repository to a specified commit.
Compiled and installed the SkyWalking agent.
Used a multi-stage Docker build to improve the final image size and only carry necessary binaries.
Docker Compose:
Modified image source to be built from the local context.
Added SW_AGENT_PHP_COMMIT as an argument to pass a specific commit of SkyWalking PHP agent.
Modified volume mounts for PHP configuration.
Entry Point:
Introduced an entrypoint script for starting up services (Nginx and PHP-FPM).
Nginx Configuration:
Added a basic Nginx configuration file to serve PHP applications and pass requests to PHP-FPM.
PHP Configuration:
Updated the SkyWalking configuration section, segregating settings for general SkyWalking and SkyWalking agent configurations.
Adjusted various settings for better integration with SkyWalking. These changes aim to streamline the PHP setup process, improve the integration with SkyWalking, and provide a more robust development and deployment experience. Feedback and reviews are highly appreciated.