Support collect ZGC memory pool metrics #11432
Conversation
|
|
| "i": "5", | ||
| "type": "Widget", | ||
| "widget": { | ||
| "title": "JVM Memory Detail (MB)" |
There was a problem hiding this comment.
Are you adding a new widget?
This name doesn't seem diff from other GC model.
| instance_jvm_memory_pool_code_cache = from(ServiceInstanceJVMMemoryPool.used).filter(poolType == MemoryPoolType.CODE_CACHE_USAGE).longAvg(); | ||
| instance_jvm_memory_pool_newgen = from(ServiceInstanceJVMMemoryPool.used).filter(poolType == MemoryPoolType.NEWGEN_USAGE).longAvg(); | ||
| instance_jvm_memory_pool_oldgen = from(ServiceInstanceJVMMemoryPool.used).filter(poolType == MemoryPoolType.OLDGEN_USAGE).longAvg(); | ||
| instance_jvm_memory_pool_survivor = from(ServiceInstanceJVMMemoryPool.used).filter(poolType == MemoryPoolType.SURVIVOR_USAGE).longAvg(); | ||
| instance_jvm_memory_pool_permgen = from(ServiceInstanceJVMMemoryPool.used).filter(poolType == MemoryPoolType.PERMGEN_USAGE).longAvg(); |
There was a problem hiding this comment.
Why these? All thses are not new metrics.
I am not following.
changes:
before:
after:Case1: app start up use default G1 gc. Case2: app start up use ZGC. |
|
Please make the submodule correctly, pointing to the master branch commit ID. |
1 similar comment
|
Please make the submodule correctly, pointing to the master branch commit ID. |
wu-sheng
added
backend
|
As you have updated UI, I think there is UI side commit gap too. Please update the UI part change logs accordingly. |
…kywalking into feature/20231013_zgc_support
|
Still missing one. 
Please check from git history https://github.com/apache/skywalking-booster-ui/commits/main |
Which one missing? There are no changes in the skywalking-booster-ui. |
|
The one I was showing above. It wasn't synced, but you are syncing sub module now, so, you need to add this to change log as well. |
wu-sheng
added
UI
* Support collect ZGC memory pool metrics * submodule update
CHANGESlog.for UI setting change, see skywalking-java #622