Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync UI #11448

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Sync UI #11448

merged 3 commits into from
Oct 23, 2023

Conversation

wu-sheng
Copy link
Member

@wu-sheng wu-sheng commented Oct 23, 2023 •
edited
Loading

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

Sync UI changes

  • Fix: avoid querying data with empty parameters.
  • Add a title and a description for trace segments

@wu-sheng wu-sheng added documentation Provide documents related issue or pull request only. UI UI and front end related. labels Oct 23, 2023
@wu-sheng wu-sheng added this to the 9.7.0 milestone Oct 23, 2023
@wu-sheng wu-sheng requested a review from a team October 23, 2023 09:56
Fine0830
Fine0830 previously approved these changes Oct 23, 2023
View reviewed changes
@Fine0830 Fine0830 self-requested a review October 23, 2023 10:41
@wu-sheng
Copy link
Member Author

My fault, the sub module is not submitted. Let's hold.

@wu-sheng wu-sheng added the don't merge Don't merge this PR until this label is removed label Oct 23, 2023
@wu-sheng wu-sheng merged commit f38a874 into master Oct 23, 2023
14 of 16 checks passed
@kezhenxu94 kezhenxu94 deleted the ui-sync branch October 23, 2023 13:25
liangyepianzhou pushed a commit to liangyepianzhou/skywalking that referenced this pull request Oct 29, 2023
@wu-sheng @liangyepianzhou
Sync UI (apache#11448)
a2576e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fine0830 Fine0830 Fine0830 approved these changes

Assignees
No one assigned
Labels
documentation Provide documents related issue or pull request only. don't merge Don't merge this PR until this label is removed UI UI and front end related.
Projects
None yet
Milestone
9.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wu-sheng @Fine0830