-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Nginx monitoring. #11558
Support Nginx monitoring. #11558
Conversation
From the screenshot, the log level is absent. |
oap-server/server-starter/src/main/resources/ui-initialized-templates/nginx/nginx-endpoint.json
Outdated
Show resolved
Hide resolved
error.log has log level, accesslog doesn't. Should I set the default log level for accesslog? |
Which logs are you gathering from accesslog? The log output should include the level, isn't it? |
nginx output accesslog and errorlog in two files, I collect both of them. error log has log level but access log doesn't. |
I think we should extract |
ok, i will extract status and level tag. |
@@ -0,0 +1,141 @@ | |||
# Nginx monitoring | |||
## Nginx performance from nginx-lua-prometheus | |||
The [nginx-lua-prometheus](https://github.com/openresty/lua-nginx-module) is a lua library that can be used with Nginx to collect metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link is wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks. I will fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@weixiang1862 Generally, this should be good. I will wait for others' review. And would you be able to add Nginx monitoring |
And I believe another blog to introduce your new thing would be cool. This should be more powerful than you introduced in the last one. WDYT? |
Yes, I will add a new blog to introduce it and add it to showcase, I think they will be ok in the end of this month. |
The time is totally flexible, and up to your reality. |
Nginx monitoring
If this is non-trivial feature, paste the links/URLs to the design doc.
Update the documentation to include this new feature.
Tests(including UT, IT, E2E) are added to verify the new feature.
If it's UI related, attach the screenshots below.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes [Feature] Support Nginx monitoring. #11534.
Update the
CHANGES
log.