Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_present function in MQE for check if the list metrics has value or not #11627

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

mrproliu
Copy link
Contributor

@mrproliu mrproliu commented Dec 5, 2023

Following #11625, I think we need an MQE function to check whether the expression contains a value or not. If contains a value(meter value is 1 means has value), then we should show the tab.

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@mrproliu mrproliu added backend OAP backend related. metrics Metrics and meter labels Dec 5, 2023
@mrproliu mrproliu added this to the 10.0.0 milestone Dec 5, 2023
wankai123
wankai123 previously approved these changes Dec 5, 2023
Copy link
Member

@wankai123 wankai123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng
Copy link
Member

wu-sheng commented Dec 5, 2023

FYI @Fine0830 You can see the response in the docs. The UI should only take type match and value is 1 as conditions to visualize the tab in the correct place, otherwise, set them disabled an the last


Expression:
```text
is_present([<expression_1>, <expression_2>, ...])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the expressions SINGLE VALUE or TIMER SERIES VALUE? Or either?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are supported.

@wu-sheng wu-sheng merged commit fcf1770 into apache:master Dec 5, 2023
167 checks passed
@mrproliu mrproliu deleted the is_present_mqe branch December 5, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. metrics Metrics and meter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants