-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max
and min
functions for mal down sampling
#11778
Conversation
…-mal-down-sampling
…of github.com:peachisai/skywalking into Support-'max'-and-min-functions-for-mal-down-sampling # Conflicts: # docs/en/changes/changes.md
…into uat2 # Conflicts: # docs/en/changes/changes.md
Support-'max'-and-min-functions-for-mal-down-sampling
Could you provide the use cases? |
I updated the use case |
Why do you need a max value? I think in most case, percentile should be better to measure latency? Does max bring a special value? |
I prefer the maximum value. This looks more intuitive. For example, with size and offset metrics. |
Size and offset make sense. But about latency, percentile is better. |
Please update the description for the meaningful use cases. |
} | ||
} | ||
|
||
@Entrance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Entrance
is misused here, and this error exists in many other MAL functions. This annotation is used in MAL engine use, in MAL, accept
method is the main entrance by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am trying to fix existing codes.
Updated |
CHANGES
log.User Case
The opentelemetry metrics
The
sum
aggregate method use 'cluster','topic' and 'group' as aggregate-by params,so I can sum the metrics of the two brokers, and then get the max message size instead of the defaultavg
function valueThe same scenario for
min
function