Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hierarchy for Pulsar #11971

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

CodePrometheus
Copy link
Contributor

Add hierarchy for Pulsar

@wu-sheng wu-sheng added this to the 10.0.0 milestone Mar 3, 2024
@wu-sheng wu-sheng added backend OAP backend related. feature New feature labels Mar 3, 2024
@wu-sheng wu-sheng requested a review from wankai123 March 3, 2024 10:59
Copy link
Member

@wankai123 wankai123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't have a showcase about PULSAR, if you have tested it, could you add some relevant screenshots?

@wu-sheng
Copy link
Member

wu-sheng commented Mar 4, 2024

@CodePrometheus Please follow the above review and resolve the conflicting.

@CodePrometheus
Copy link
Contributor Author

Sorry, I've been busy with work lately. The showcase is in progress, and local test is as shown below, but the service_hierarchy_relation does not seem to be related to Virtual-MQ and Pulsar-cluster now, I'm still trying to figure it out, If teachers have any suggestions please let me know, thanks very much.
image
image
image

@wu-sheng
Copy link
Member

wu-sheng commented Mar 6, 2024

From what I saw, your V-MQ is using IP:port which is provided by the agent plugin, meanwhile, server monitoring is using service name in k8s or something similar. You build the hierarchy rules, you need to make sure whey are aligned and the rules follow the setup.

@peachisai
Copy link
Contributor

peachisai commented Mar 7, 2024

Due to the difficulty of building the IP:port format relationship with the Pulsar-cluster ,I suggest adjusting local hosts to accommodate the Pulsar-cluster name If Pulsar java plugin report the address name as I suppose

@CodePrometheus
Copy link
Contributor Author

Due to the difficulty of building the IP:port format relationship with the Pulsar-cluster ,I suggest adjusting local hosts to accommodate the Pulsar-cluster name If Pulsar java plugin report the address name as I suppose

It works, @peachisai You’re a genius! Very thanks~
image

And I have an idea, is it possible to declare an empty custom key in auto-matching-rules, such as custom: ""

@wu-sheng
Copy link
Member

wu-sheng commented Mar 7, 2024

Please resolve the conflicts.

@wu-sheng wu-sheng merged commit c5e0f5f into apache:master Mar 8, 2024
150 checks passed
@CodePrometheus CodePrometheus deleted the feat_pulsar branch March 8, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants