bug fix: concurrent increase by CounterWindow may cause PriorityQueue breaken

[kael-aiur]

Fix <#12503>

• Add a unit test to verify that the fix works.
• Explain briefly why the bug exists and how to fix it.

as org.apache.skywalking.oap.meter.analyzer.dsl.counter.CounterWindow are single instance, the windows which type ConcurrentHashMap will return the same PriorityQueue object for the same meter, when the same meter increase with concurrent call, some unexcpected exception will occur in PriorityQueue object, source code:

public class CounterWindow {

    public static final CounterWindow INSTANCE = new CounterWindow();

    private final Map<ID, Tuple2<Long, Double>> lastElementMap = new ConcurrentHashMap<>();
    private final Map<ID, Queue<Tuple2<Long, Double>>> windows = new ConcurrentHashMap<>();

    public Tuple2<Long, Double> increase(String name, ImmutableMap<String, String> labels, Double value, long windowSize, long now) {
        ID id = new ID(name, labels);
        // there will return the same PriorityQueue object for concurrent operation
        Queue<Tuple2<Long, Double>> window = windows.computeIfAbsent(id, unused -> new PriorityQueue<>());
        window.offer(Tuple.of(now, value));  // some unexpected error will occur in this line when concurrent operation
        long waterLevel = now - windowSize;
        Tuple2<Long, Double> peek = window.peek();
        if (peek._1 > waterLevel) {
            return peek;
        }

        Tuple2<Long, Double> result = peek;
        while (peek._1 < waterLevel) {
            result = window.poll();  // some unexpected error will occur in this line when concurrent operation
            peek = window.element();  // some unexpected error will occur in this line when concurrent operation
        }

        // Choose the closed slot to the expected timestamp
        if (waterLevel - result._1 <= peek._1 - waterLevel) {
            return result;
        }

        return peek;
    }
    //....
}

• If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #12503.
• Update the CHANGES log.

[wu-sheng]

@kezhenxu94 Docker compose somehow missing. Could you check CI env as well?

[peachisai]

@kezhenxu94 Docker compose somehow missing. Could you check CI env as well?

I had the same problem as well, I think the command docker compose should instead docker-compose
Ref actions/runner-images#9557

[wu-sheng]

@kezhenxu94 Docker compose somehow missing. Could you check CI env as well?

I had the same problem as well, I think the command docker compose should instead docker-compose

Ref actions/runner-images#9557

We fixed it through new e2e tool version.