Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize metrics of minute dimensionality persistence, don't save metric of being default value. #8066

Merged
merged 4 commits into from
Nov 4, 2021

Conversation

wu-sheng
Copy link
Member

@wu-sheng wu-sheng commented Nov 3, 2021

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

Optimize metrics of minute dimensionality persistence.

  • The value of metrics, which has declaration of the default value and current value equals the default value logically, the whole row wouldn't be pushed into database.
  • Add self-observability metrics_persistence_skipped metric to measure the number of skipped metrics.
  • SLA(percent function), Apdex, AvgLong(MAL mostly) metrics are mostly optimized because of this. Such as a full-failing error(0% successful rate) and unhealthy(apdex=0) are not costing the storage.
  • Hour/Day dimensionalities metrics are not changed, as they cover long duration.
  • Fix max function in OAL doesn't support negative long.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
- The value of metrics, which has declaration of the default value and current value equals the default value logically, the whole row wouldn't be pushed into database.
@wu-sheng wu-sheng added core feature Core and important feature. Sometimes, break backwards compatibility. backend OAP backend related. enhancement Enhancement on performance or codes labels Nov 3, 2021
@wu-sheng wu-sheng added this to the 8.9.0 milestone Nov 3, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@wu-sheng wu-sheng requested a review from hanahmily November 3, 2021 13:09

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@wu-sheng wu-sheng requested a review from wankai123 November 3, 2021 15:11
Copy link
Member

@wankai123 wankai123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit c0994ee into master Nov 4, 2021
@wu-sheng wu-sheng deleted the opt branch November 4, 2021 01:38
wu-sheng added a commit that referenced this pull request Jul 12, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@wu-sheng wu-sheng mentioned this pull request Jul 12, 2022
2 tasks
wu-sheng added a commit that referenced this pull request Jul 13, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Revert #8066

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. core feature Core and important feature. Sometimes, break backwards compatibility. enhancement Enhancement on performance or codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants