SLING-12474 - Incorrect repoinit statements generated for bundles embedded more than once at different paths #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edded more than once at different paths Switch sub content-package inclusion check to package ids.
|
Draft because while this solves the problem I am not 100% sure that this is the right thing to do. Perhaps we should not generate repoinit statements at all while processing a bundle for the second time. |
|
Thinking about it some more, I think that this will have the side effect of processing identical sub-content packages more than once if defined in more than one location, which might have undesired side effects. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch sub content-package inclusion check to package ids.