SOLR-16360: Atomic update on boolean fields doesn't reflect when value starts with "1", "t" or "T" #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulgoswami
changed the title
|
Can you add a test please? |
|
On it! |
|
Are we able to reuse the code from StrUtils for this instead of duplicating? |
|
Added tests and incorporated Justin's comment. |
… to avoid having to change the latter for atomic update
dsmiley
reviewed
Aug 6, 2023
…to centralize the boolean check
|
Can you please add an entry to CHANGES.txt under 9.4 (the next release) |
|
Would it make sense for this to be considered for 8.11.3 release next month ? |
|
Yes (if you want to back-port), but that shouldn't affect CHANGES.txt for now because that's a special situation. |
|
This is done. Awaiting review. Thanks. |
# Conflicts: # solr/CHANGES.txt
dsmiley
pushed a commit
that referenced
this pull request
Aug 9, 2023
…e starts with "1", "t" or "T" (#1816) * StrUtils.parseBoolean() can accept a CharSequence --------- Co-authored-by: Rahul Goswami <rgoswami@commvault.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16360
Description
Added a change in toNativeType(Object val) method of BoolField.java to check for the first character of val and return true if it is '1', 't' or 'T'
Solution
Added a change in toNativeType(Object val) method of BoolField.java to check for the first character of val and return true if it is '1', 't' or 'T'
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.