Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-16950 SimpleTracer propagation for manual transaction ids #1906

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

stillalex
Copy link
Member

https://issues.apache.org/jira/browse/SOLR-16950

Description

Fix support for client side manual transaction ids on UpdateRequest.
Currently due to UpdateRequest getting recreated, the headers are lost so propagation is broken.

Solution

Please provide a short description of the approach taken to implement your solution.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@stillalex stillalex merged commit 6d7b68a into apache:main Sep 15, 2023
3 checks passed
@stillalex stillalex deleted the SOLR-16950-manual-ids branch September 15, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant