SOLR-16995 Add a ReplicaCount to keep track of replicas per type #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this can benefit from a JIRA issue? |
sigram
reviewed
Sep 22, 2023
solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java
Outdated
Show resolved
Hide resolved
|
@janhoy You're right, I created one: https://issues.apache.org/jira/browse/SOLR-16995 |
|
Furthermore, PRs titles must start with a JIRA reference (assuming there is one); that's how they are linked. I'll change that now. |
dsmiley
changed the title
dsmiley
reviewed
Oct 4, 2023
solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java
Outdated
Show resolved
Hide resolved
dsmiley
reviewed
Oct 4, 2023
solr/core/src/java/org/apache/solr/cluster/placement/impl/PlacementRequestImpl.java
Outdated
Show resolved
Hide resolved
dsmiley
reviewed
Oct 4, 2023
solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java
Outdated
Show resolved
Hide resolved
pvcnt
force-pushed
the
replica-count
branch
2 times, most recently
from
c4d54ec
to
9818111
Compare
7 tasks
|
I split the changes related to using |
|
HdfsCloudIncrementalBackupTest has been flapping since 2022-08, and lately steadily increasing. |
7 tasks
This was referenced Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16995
Description
Working with replica counts, i.e., the number of replicas per replica type, is currently a bit painful, as the number of replicas is tracked individually for every replica type via individual variables. Solving this issue is also a step towards making it easier to add new replica types.
Solution
This PR introduces a
ReplicaCountclass (there was one up to Solr 8.x in the autoscaling framework, but it was removed in Solr 9) that is fancy wrapper around a Map<Replica.Type, Integer>.Tests
New tests for the
ReplicaCountclass. Existing tests ensure non-regression (there is no added feature).Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.