Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MoveReplicaHdfsFailoverTest after SOLR-16962 #2525

Conversation

magibney
Copy link
Contributor

the changes made by SOLR-16962 to ZkController and MoveReplicaCmd resolve the conflation of ulog and tlog dir, and remove some related hacky compensations for this conflation. The nightly test MoveReplicaHdfsFailoverTest was still compensating for this issue when it no longer needs to, and was thus failing.

(no jira)

the changes made by SOLR-16962 to ZkController and MoveReplicaCmd
resolve the conflation of ulog and tlog dir, and remove some
related hacky compensations for this conflation. The nightly test
MoveReplicaHdfsFailoverTest was still compensating for this issue
when it no longer needs to, and was thus failing.
Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning things up!!!

@magibney magibney merged commit 4a12f8a into apache:main Jun 19, 2024
3 checks passed
magibney added a commit that referenced this pull request Jun 19, 2024
the changes made by SOLR-16962 to ZkController and MoveReplicaCmd
resolve the conflation of ulog and tlog dir, and remove some
related hacky compensations for this conflation. The nightly test
MoveReplicaHdfsFailoverTest was still compensating for this issue
when it no longer needs to, and was thus failing.

(cherry picked from commit 4a12f8a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants