Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support Lucene's (proposed) HNSW search seeding feature #2664

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

support Lucene's (proposed) HNSW search seeding feature #2664

wants to merge 1 commit into from

Conversation

cpoerschke
Copy link
Contributor

See apache/lucene#13634 issue and @seanmacavaney's apache/lucene#13635 draft for context.

dsmiley
dsmiley reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@dsmiley dsmiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not seen a Solr PR that depends on a Lucene PR that is unmerged :-). It's getting ahead of ourselves. Is the point to see if there are API problems in Solr code?

@cpoerschke
Copy link
Contributor Author

I've not seen a Solr PR that depends on a Lucene PR that is unmerged :-). It's getting ahead of ourselves. Is the point to see if there are API problems in Solr code?

Yes, to gauge what this might look like from the Solr/application perspective, e.g.

  • it seems straightforward to support,
  • (perhaps) clarifies that (currently) there is no "how many" number associated with the seed query, and
  • the seed query will need a parameter name, obviously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsmiley dsmiley dsmiley left review comments

Assignees
No one assigned
Labels
cat:schema cat:search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpoerschke @dsmiley