Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17439 Fix missing documentation for finding out non-standard PID for Solr in Docker #2705

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

rmueller83
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-17439

Description

The documentation misses a section for finding out a non-default PID.

Solution

Added a ps command for finding the PID.

Tests

I successfully executed the command in a running Solr 9.6.1 and 9.7.0 container.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at this in context o fthe page, becasue at first I thought it was "too simple" and I agree it's a nice helper! Plus not everyone has years of java ops experience ;-)

@janhoy
Copy link
Contributor

janhoy commented Sep 12, 2024

Hi, thanks for this. It's a tiny doc change, so normally we don't attribute it in CHANGES.txt and in release notes. However, we encourage you to keep contributing and for a more substantial change you'll for sure be mentioned :)

I'll back port this to 9x and 9.7 since our refguide docs can be fixed retroactively outside releases :)

@janhoy janhoy merged commit c57c6d9 into apache:branch_9_7 Sep 12, 2024
2 checks passed
janhoy pushed a commit that referenced this pull request Sep 12, 2024
@janhoy
Copy link
Contributor

janhoy commented Sep 12, 2024

Realized too late that the PR was against branch_9_7. Normally we make changes to main first and then back port. This time I'll forward port to main...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants