-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-17473: Introduce build tools formatting #2739
SOLR-17473: Introduce build tools formatting #2739
Conversation
Migrate buildSrc into a composite included build (build-infra). Expose a plugin with buildinfra extension.
b545050
to
97a8c99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had no idea we had so many .java files related to doing our builds. I am always in favour of having more code strictness in an environment where many cooks are in the kitchen!
^ @malliaridis I triggered the github build and looks like something burped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since some of the build infra source files come from Lucene in their entirety, why not leave them be in the Lucene namespace? Lucene & Solr continue to have a build that's rather aligned, allowing taking of changes from one project to the other.
This reverts commit 97a8c99.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did another short look in a hurry. If I had more time, I might compare to Lucene project but I don't. +1 approval from me. I'll merge tomorrow but maybe sooner with someone else's +1.
https://issues.apache.org/jira/browse/SOLR-17473
Description
With the build tools persisting of various Java files, formatting and checking tools should also be run on these files.
Solution
This PR migrates the
buildSrc
to composite build project, as demonstrated in apache/lucene#13484 and applied in #2706 (with minor adjustments).Tests
No tests have been added or altered.
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.