SOLR-17256: Nuke SolrRequest set/getBasePath in 10 #2852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous commits removed all usage of these methods, but held off on actually removing the deprecated methods themselves. This commit now takes the final step of doing that removal. Should not be backported to branch_9x, as the deprecated methods are required to remain there for the remainder of the 9.x release line.
github-actions
bot
added
the
documentation
dsmiley
reviewed
Nov 7, 2024
Comment on lines
-94
to
+83
| String path = requestWriter.getPath(solrRequest); | ||
| String path = solrRequest.getPath(); |
There was a problem hiding this comment.
You haven't removed the deprecated RequestWriter.getPath in Solr 10; shouldn't you?
There was a problem hiding this comment.
I would've sworn that I had. But I must've missed it somehow. Anyways, done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17256
Description
Previous PRs removed all use of getBasePath/setBasePath, but didn't remove the methods themselves to facilitate easier backporting.
Solution
This commit removes these methods from 'main'. It's NOT intended for backporting, as setBasePath/getBasePath are required to stick around on branch_9x through the remainder of the 9x release line.
Tests
N/A
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.