-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade-log4j2-2.24.2 #2895
base: main
Are you sure you want to change the base?
upgrade-log4j2-2.24.2 #2895
Conversation
Looks like we are running into:
Once those are fixed (there is a PR it looks like) should be ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of dependency updates during the downtime of our bot. 😄
Could you update the license files of
- slf4j-api
- jul-to-slf4j
- jcl-over-slf4j, this changed from MIT to ASL in repo, but is still using the base license in downloaded package. Not sure which one to use in this case. @janhoy any idea how to handle these cases? Prefer ASL?
Also you can remove the content of:
- slf4j-NOTICE.txt (as it does not exist anymore according to repo)
- jul-to-slf4j-NOTICE.txt (as it does not exist anymore according to repo)
- jcl-over-slf4j-NOTICE.txt (as it does not exist anymore according to repo)
And since you are already updating the libraries, you may consider merging the log4j-*-LICENSE.txt
(6 files) into log4j-LICENSE.txt
and log4j-*-NOTICE.txt
(6 files) into log4j-NOTICE.txt
, as they all share now the same license and notice file according to repo (see log4j).
I think our license file checker does not recognize the slf4j group for the jul-to-slf4j and jcl-over-slf4j libraries, otherwise we could merge these as well.
I'll cut a |
I have no preference when license is ambiguous. Guess whatever is in the download tar for that version is safe. |
Since you use Log4j Core in your binary distribution, you should consider using the JUL-to-Log4j API bridge instead. The artifact has two modi operandi:
Since the release of |
https://issues.apache.org/jira/browse/SOLR-XXXXX
This is a follow on to #2047 where
biz.aQute.bnd
doesn't need to be upgraded.However running into some test failures due to concurrent modification exceptions when updating loggers in some tests.