Skip to content

Conversation

@Yikun
Copy link
Member

@Yikun Yikun commented May 6, 2023

What changes were proposed in this pull request?

Why are the changes needed?

Same change with build workflow refactor, to avoid the publish issue like:

#5 [linux/amd64 internal] load metadata for docker.io/library/spark:3.4.0-scala2.12-java11-ubuntu
#5 ERROR: pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed
------
 > [linux/amd64 internal] load metadata for docker.io/library/spark:3.4.0-scala2.12-java11-ubuntu:
------
Dockerfile:18
--------------------
  16 |     #
  17 |     ARG BASE_IMAGE=spark:3.4.0-scala2.12-java11-ubuntu
  18 | >>> FROM $BASE_IMAGE
  19 |     
  20 |     RUN set -ex && \
--------------------
ERROR: failed to solve: spark:3.4.0-scala2.12-java11-ubuntu: pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed
Error: buildx failed with: ERROR: failed to solve: spark:3.4.0-scala2.12-java11-ubuntu: pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed

Does this PR introduce any user-facing change?

No

How was this patch tested?

Publish test in my local fork:

image

#3 [linux/amd64 internal] load metadata for ghcr.io/yikun/spark-docker/spark:3.4.0-scala2.12-java11-ubuntu
#3 DONE 0.9s

#4 [linux/arm64 internal] load metadata for ghcr.io/yikun/spark-docker/spark:3.4.0-scala2.12-java11-ubuntu
#4 DONE 0.9s
  • CI passed: do local base build first and build base on the local build

@Yikun Yikun marked this pull request as draft May 6, 2023 06:19
@Yikun Yikun force-pushed the publish-build branch 4 times, most recently from 4fee88f to e1af17e Compare May 6, 2023 07:21
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun Yikun force-pushed the publish-build branch from e1af17e to 3224ebb Compare May 6, 2023 07:54
@Yikun Yikun marked this pull request as ready for review May 6, 2023 09:02
@Yikun
Copy link
Member Author

Yikun commented May 6, 2023

cc @HyukjinKwon @zhengruifeng

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun Yikun marked this pull request as draft May 25, 2023 06:54
@Yikun Yikun marked this pull request as ready for review May 25, 2023 08:12
@Yikun Yikun closed this in f2d2b2d May 25, 2023
@Yikun
Copy link
Member Author

Yikun commented May 25, 2023

@HyukjinKwon Thanks! my local publish test and ci passed, so merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants