Update release process to use Python 3 for Python API documentation #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixcheung
reviewed
Jul 9, 2018
| - Ensure you have the required dependencies to build the docs `docs/README.md` | ||
| - R, for CRAN packaging tests, requires e1071 to be installed as part of the packaging tests. | ||
| - In addition R uses LaTeX for some things, and requires some additional fonts. On Debian based systems you may wish to install `texlive-fonts-recommended` and `texlive-fonts-extra`. | ||
| - Make sure you required Python packages for packaging (see `dev/requirements.txt`) |
Member
There was a problem hiding this comment.
should we put that (sphinx) into dev/requirements.txt?
Member
Author
There was a problem hiding this comment.
Indeed yea I think we should.
asfgit
pushed a commit
to apache/spark
that referenced
this pull request
Jul 10, 2018
## What changes were proposed in this pull request? Not a big deal but this PR adds `sphinx` into `dev/requirements.txt` since we found it needed - apache/spark-website#122 (comment) ## How was this patch tested? manually: ``` pip install -r requirements.txt ``` Author: hyukjinkwon <gurwls223@apache.org> Closes #21735 from HyukjinKwon/minor-dev.
HyukjinKwon
force-pushed
the
update-release-process
branch
from
ef8f5c5 to
a678871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to set
SPHINXPYTHONenvironment variable to work around missing signatures.Note that this PR is dependent on apache/spark#21659.