Skip to content

Conversation

@kayousterhout
Copy link
Contributor

@kayousterhout kayousterhout commented Feb 12, 2017

This moves the information about how to run individual tests and use Zinc to the developer tools page, from the release-specific docs. I've found the developer tools page is more Google-able, this info is useful primarily for developers, and it doesn't change significantly between releases. There's a companion PR in the main Spark repo to remove this from the release-specific docs: apache/spark#17018

This is useful and I often forget how to do it.  I learned some
new tricks when @squito gave @jinxing64 some tips on how to do
this, so I thought it was worth adding this to the website.
@srowen
Copy link
Member

srowen commented Feb 12, 2017

I didn't copy this from the wiki because it had been added earlier to the docs at http://spark.apache.org/docs/latest/building-spark.html#running-tests That doesn't mean it's the best place for this piece of info. If you'd like to add this then just also make a PR to remove similar info in the release-specific docs (perhaps with a pointer to this new info)

@kayousterhout
Copy link
Contributor Author

Ah thanks for the pointer to that -- I hadn't seen that page. It looks like the Building Spark page has some stuff that's really only for developers (mainly the Zinc info and how to run individual tests). What do you think about me moving all of that (so the Zinc info in addition to the individual tests info) to the developers page, and then adding a link on the building spark page to the developer page for more info on running tests?

If I do that, do you think I should move all of the "testing" info to the developer page? I'm inclined to think no because I can imagine non-developers wanting to run all of the tests (e.g., to verify a release), but figured you'd have better visibility into this, so wanted to check.

@srowen
Copy link
Member

srowen commented Feb 14, 2017

Feel free to move whatever you think should be moved. When I merged the wiki into the main site it was a rough cut at fitting bits together that weren't necessarily in the best place, so more editing is certainly welcome.

I can help review and merge this and/or the complementary change to the main docs whenever you're ready.

@srowen
Copy link
Member

srowen commented Feb 21, 2017

@kayousterhout are you interested in updating the main project docs too? we can commit both changes.

@kayousterhout
Copy link
Contributor Author

Yup sorry for the delay on this -- was out on vacation. I'll do both today.

@kayousterhout kayousterhout changed the title Added instructions for running individual tests Move information about Zinc and running individual tests to main website Feb 21, 2017
kayousterhout added a commit to kayousterhout/spark-1 that referenced this pull request Feb 21, 2017
This commit moves developer-specific information from the release-
specific documentation in this repo to the developer tools page on
the main Spark website. This commit relies on this PR on the
Spark website: apache/spark-website#33.
@kayousterhout
Copy link
Contributor Author

Ok I updated this to add the Zinc stuff, and also added a corresponding PR in the main Spark repo. We should merge this one first so the links I added in the Spark release-specific docs work.

@srowen
Copy link
Member

srowen commented Feb 22, 2017

@kayousterhout this is merged now though it won't auto-close because I rebased/squashed

@kayousterhout
Copy link
Contributor Author

Cool thanks for the help with this Sean

Yunni pushed a commit to Yunni/spark that referenced this pull request Feb 27, 2017
This commit moves developer-specific information from the release-
specific documentation in this repo to the developer tools page on
the main Spark website. This commit relies on this PR on the
Spark website: apache/spark-website#33.

srowen

Author: Kay Ousterhout <kayousterhout@gmail.com>

Closes apache#17018 from kayousterhout/SPARK-19684.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants