-
Notifications
You must be signed in to change notification settings - Fork 231
New home page and layout for Spark website #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
HyukjinKwon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed offline before this PR. LGTM from my side but would better to have a second look
|
Looks nice, but I am bit concerned about the contrast ratio. If we had body {
color: #555555;
...
}it should still look good, IMHO, but exceed WCAG AAA on normal text (going from 5.74:1 to 7.45:1). |
|
@zero323 Thanks for the suggestion. Even though it fails WCAG AAA, but it still passes WCAG AA. I prefer the current color (#666666) since it looks more comfortable on my first impression. I made two screenshots. If there are more suggestions to change the color, I will update it. |
|
New look is very impressive, @gengliangwang . :) |
holdenk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new design, thanks for working on this :)
I think there are maybe some things we could follow up on (e.g. only Python has install instructions on the main page), but we can leave the fine-tuning until post-merge this is definitely an improvement over what we have now
gatorsmile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
|
This looks great to me, very excited about it. We should definitely keep improving it over time, for instance with better code examples and setup instructions in all the languages if applicable. My only comment on that is to make sure to keep the first example people see small. The other tabs can contain more stuff. |
|
LGTM |
|
Merged. Thanks all for the review! |
|
Late LGTM. Looks nice! |


This PR introduces a new UI for the Spark Website, including:
To preview the new website, check http://ec2-54-184-63-212.us-west-2.compute.amazonaws.com