Skip to content

Conversation

@gengliangwang
Copy link
Member

This PR introduces a new UI for the Spark Website, including:

  • A new home page
  • A new global layout template
  • Update title case capitalization of each page

To preview the new website, check http://ec2-54-184-63-212.us-west-2.compute.amazonaws.com

@gengliangwang
Copy link
Member Author

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed offline before this PR. LGTM from my side but would better to have a second look

@zero323
Copy link
Member

zero323 commented Oct 11, 2021

Looks nice, but I am bit concerned about the contrast ratio. If we had

body {
    color: #555555;
    ...
}

it should still look good, IMHO, but exceed WCAG AAA on normal text (going from 5.74:1 to 7.45:1).

@gengliangwang
Copy link
Member Author

@zero323 Thanks for the suggestion. Even though it fails WCAG AAA, but it still passes WCAG AA. I prefer the current color (#666666) since it looks more comfortable on my first impression.

I made two screenshots. If there are more suggestions to change the color, I will update it.
#666666
image

#555555
image

@dongjoon-hyun
Copy link
Member

New look is very impressive, @gengliangwang . :)

Copy link
Contributor

@holdenk holdenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new design, thanks for working on this :)

I think there are maybe some things we could follow up on (e.g. only Python has install instructions on the main page), but we can leave the fine-tuning until post-merge this is definitely an improvement over what we have now

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mateiz
Copy link
Contributor

mateiz commented Oct 12, 2021

This looks great to me, very excited about it. We should definitely keep improving it over time, for instance with better code examples and setup instructions in all the languages if applicable. My only comment on that is to make sure to keep the first example people see small. The other tabs can contain more stuff.

@yaooqinn
Copy link
Member

LGTM

@gengliangwang gengliangwang merged commit 1df3f0a into apache:asf-site Oct 12, 2021
@gengliangwang
Copy link
Member Author

Merged. Thanks all for the review!

@HeartSaVioR
Copy link
Contributor

Late LGTM. Looks nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants