[SPARK-44820][DOCS] Switch languages consistently across docs for all code snippets #474
Conversation
|
cc @zhengruifeng |
|
Hi @panbingkun this is an important bug fix and we should merge it! Shall we re-open this? |
Actually, this feature has been fixed in We have two options for the logic of history
|
|
Yea we should apply the change in the |
If we are not suitable for republishing historically published documents, we can only manually update them on Spark website. If necessary, I can complete it. |
|
@panbingkun yes let's update the spark website (this repo) to fix this UI issue for published docs. |
Okay, let me to fix it. |
… across docs for all code snippets The pr aims to fix UI issue for `published docs` about Switch languages consistently across docs for all code snippets #474 (comment) <img width="912" alt="image" src="https://github.com/apache/spark-website/assets/15246973/50b86a6f-4bde-4444-93bf-cb85b66e962c"> As discussed, we aim to fix the aforementioned issues by directly repairing files that have already been released in history. include versions: 3.1.1, 3.1.2, 3.1.3, 3.2.0, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.3.0, 3.3.1, 3.3.2, 3.3.3, 3.4.0, 3.4.1 Manually test: ``` bundle exec jekyll serve --watch ``` Author: panbingkun <pbk1982@gmail.com> Closes #480 from panbingkun/fix_history_switch.
2 participants
When a user chooses a different language for a code snippet, all code snippets on that page should switch to the chosen language. This was the behavior for, for example, Spark 2.0 doc: https://spark.apache.org/docs/2.0.0/structured-streaming-programming-guide.html
But it was broken for later docs, for example the Spark 3.4.1 doc: https://spark.apache.org/docs/latest/quick-start.html
We should fix this behavior change and possibly add test cases to prevent future regressions.
Jira: https://issues.apache.org/jira/browse/SPARK-44820