Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make hyperlinks clickable & fix link #475

Closed

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Sep 8, 2023

The pr aims to:

  • make hyperlinks clickable to improve document usability
  • fix some link to reduce one jump.

@@ -197,8 +197,8 @@ origin git@github.com:[your username]/spark.git (push)
For the `apache` repo, you will need to set up command-line authentication to GitHub. This may
include setting up an SSH key and/or personal access token. See:

- https://help.github.com/articles/connecting-to-github-with-ssh/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original address has outdated, and a redirect will occur here.

an admin to add the person to Contributors at
https://issues.apache.org/jira/plugins/servlet/project-config/SPARK/roles .</p>
an admin to add the person to Contributors at
<a href="https://issues.apache.org/jira/plugins/servlet/project-config/SPARK/roles">https://issues.apache.org/jira/plugins/servlet/project-config/SPARK/roles</a> .</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this outdated sentences completely because of apache/spark#42653

However where the contributor is not yet a part of the
Contributors group for the Spark project in ASF JIRA, it won’t work until they are added. Ask ...

cc @yaooqinn who is the main author of that improvement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (with one minor comment)

@@ -7,7 +7,7 @@ Building the site requires [Jekyll](http://jekyllrb.com/docs)
The easiest way to install the right version of these tools is using
[Bundler](https://bundler.io/) and running `bundle install` in this directory.

See also https://github.com/apache/spark/blob/master/docs/README.md
See also [https://github.com/apache/spark/blob/master/docs/README.md](https://github.com/apache/spark/blob/master/docs/README.md)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although README.md does not generate a corresponding README.html page in the spark website project,
I believe that for consistency, the following statement still needs to be modified.

@panbingkun
Copy link
Contributor Author

Similar issues with spark project have also been submitted: apache/spark#42854.

@srowen srowen closed this in 642d1fb Sep 9, 2023
@srowen
Copy link
Member

srowen commented Sep 9, 2023

Merge to asf-site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants