Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-45195][FOLLOWUP] Update python example #478

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

zhengruifeng
Copy link
Contributor

To address #477 (comment)

image

index.md Outdated
<p>$ docker run -it --rm spark:python3 /opt/spark/bin/pyspark</p>
<p>$ </p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line?

index.md Outdated
</div>
<div class="code">
<p>$ pip install pyspark</p>
<p>$ pyspark</p>
<p>$ </p>
</div>
<div style="font-size: 16px;">Try offical image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: offical => official

Use the official Docker image.

address comments

address comments
@zhengruifeng zhengruifeng changed the title [SPARK-45195] Update python example [SPARK-45195][FOLLOWUP] Update python example Sep 19, 2023
@zhengruifeng zhengruifeng merged commit c578724 into apache:asf-site Sep 19, 2023
1 check passed
@zhengruifeng zhengruifeng deleted the update_py_example branch September 19, 2023 05:53
@zhengruifeng
Copy link
Contributor Author

thank you guys

Copy link
Contributor

@allisonwang-db allisonwang-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

</div>
<div class="code">
<p>$ pip install pyspark</p>
<p>$ pyspark</p>
<p>$ </p>
</div>
<div style="font-size: 16px;">Use the official Docker image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: it would be great to hyperlink this Docker image (if it is not mentioned anywhere else).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants