Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the canonical link, due to a change in some addresses in the latest version of the document #483

Closed

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Oct 17, 2023

The pr is followup #482.

#482 (comment)
As discussed above, due to changes in some document addresses after version 3.3.0, the canonical link is incorrect. We are now correcting it.

Base on rule:
For file that do not exist in version latest, delete the corresponding ref and update it for the rest.

@panbingkun
Copy link
Contributor Author

cc @allanf-db @HyukjinKwon @zhengruifeng @allisonwang-db @srowen

Copy link
Contributor

@allisonwang-db allisonwang-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not take a close look but seems fine

@allisonwang-db
Copy link
Contributor

This should be good to go. I've checked the canonical link for 3.1.1 gruopBy doc is correctly pointing to the latest one :)

@panbingkun
Copy link
Contributor Author

In order to prevent possible merge conflicts, after this PR, I will add Matomo analytics to the already published HTML document.

@allisonwang-db
Copy link
Contributor

Sounds good. cc @HyukjinKwon this one should be ready to go

@HyukjinKwon
Copy link
Member

Merged to asf-site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants