[SPARK-12023][BUILD] Fix warnings while packaging spark with maven. #10014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Seems OK, but the warning indicates it was interpreted as an absolute path before, but it wasn't. Hm. |
|
Test build #46813 has finished for PR 10014 at commit
|
|
Test build #2124 has finished for PR 10014 at commit
|
Member
|
@ScrapCodes I'm pretty happy to merge this, but how did this work before, if it was interpreted as absolute? that seems to be what the warning says. |
Member
Author
|
According to the SO post this warning is added in recent versions of assembly plugin. So I think it was not a problem before, even now it just fixes that warning. |
Member
|
Merged to master/1.6 |
asfgit
pushed a commit
that referenced
this pull request
Nov 30, 2015
this is a trivial fix, discussed [here](http://stackoverflow.com/questions/28500401/maven-assembly-plugin-warning-the-assembly-descriptor-contains-a-filesystem-roo/). Author: Prashant Sharma <scrapcodes@gmail.com> Closes #10014 from ScrapCodes/assembly-warning. (cherry picked from commit bf0e85a) Signed-off-by: Sean Owen <sowen@cloudera.com>
Member
Author
|
Thanks @srowen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a trivial fix, discussed here.