Skip to content

[SPARK-1994][SQL] Weird data corruption bug when running Spark SQL on data in HDFS #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marmbrus wants to merge 1 commit into from
Closed

[SPARK-1994][SQL] Weird data corruption bug when running Spark SQL on data in HDFS #1004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/Aggregate.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,7 @@ case class Aggregate(
resultAttribute: AttributeReference)

/** A list of aggregates that need to be computed for each group. */
@transient
private[this] lazy val computedAggregates = aggregateExpressions.flatMap { agg =>
private[this] val computedAggregates = aggregateExpressions.flatMap { agg =>
agg.collect {
case a: AggregateExpression =>
ComputedAggregate(
Expand All @@ -89,8 +88,7 @@ case class Aggregate(
}.toArray

/** The schema of the result of all aggregate evaluations */
@transient
private[this] lazy val computedSchema = computedAggregates.map(_.resultAttribute)
private[this] val computedSchema = computedAggregates.map(_.resultAttribute)

/** Creates a new aggregate buffer for a group. */
private[this] def newAggregateBuffer(): Array[AggregateFunction] = {
Expand All @@ -104,8 +102,7 @@ case class Aggregate(
}

/** Named attributes used to substitute grouping attributes into the final result. */
@transient
private[this] lazy val namedGroups = groupingExpressions.map {
private[this] val namedGroups = groupingExpressions.map {
case ne: NamedExpression => ne -> ne.toAttribute
case e => e -> Alias(e, s"groupingExpr:$e")().toAttribute
}
Expand All @@ -114,16 +111,14 @@ case class Aggregate(
* A map of substitutions that are used to insert the aggregate expressions and grouping
* expression into the final result expression.
*/
@transient
private[this] lazy val resultMap =
private[this] val resultMap =
(computedAggregates.map { agg => agg.unbound -> agg.resultAttribute } ++ namedGroups).toMap

/**
* Substituted version of aggregateExpressions expressions which are used to compute final
* output rows given a group and the result of all aggregate computations.
*/
@transient
private[this] lazy val resultExpressions = aggregateExpressions.map { agg =>
private[this] val resultExpressions = aggregateExpressions.map { agg =>
agg.transform {
case e: Expression if resultMap.contains(e) => resultMap(e)
}
Expand Down