Skip to content

Conversation

@marmbrus
Copy link
Contributor

@marmbrus marmbrus commented Dec 1, 2015

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marmbrus Primitive types mentioned twice ? Is it ok ?

@SparkQA
Copy link

SparkQA commented Dec 1, 2015

Test build #46946 has finished for PR 10060 at commit 649541c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be mistaken but I think you meant to write "through" and not "though".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be great to expand this slightly and explain what can be inferred automatically right now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import order

@SparkQA
Copy link

SparkQA commented Dec 3, 2015

Test build #47151 has finished for PR 10060 at commit 3e53a4c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

benifits -> benefits

@SparkQA
Copy link

SparkQA commented Dec 8, 2015

Test build #47356 has finished for PR 10060 at commit 3ff7a46.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a word missing between "more" and "about" like information?

@BenFradet
Copy link
Contributor

I made a few comments, but otherwise it's clear.

@marmbrus
Copy link
Contributor Author

marmbrus commented Dec 8, 2015

Thanks for the comments!

@SparkQA
Copy link

SparkQA commented Dec 8, 2015

Test build #47366 has finished for PR 10060 at commit 4b51ad7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@marmbrus marmbrus changed the title [WIP][SPARK-12069][SQL] Update documentation with Datasets [SPARK-12069][SQL] Update documentation with Datasets Dec 8, 2015
asfgit pushed a commit that referenced this pull request Dec 8, 2015
Author: Michael Armbrust <michael@databricks.com>

Closes #10060 from marmbrus/docs.

(cherry picked from commit 3959489)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@asfgit asfgit closed this in 3959489 Dec 9, 2015
@marmbrus marmbrus deleted the docs branch March 8, 2016 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants