Skip to content

[SPARK-4117] [YARN] Spark on Yarn handle AM being told command from RM #10129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devaraj-kavali wants to merge 3 commits into from
Closed

[SPARK-4117] [YARN] Spark on Yarn handle AM being told command from RM #10129

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
636fd78
Spark on Yarn handle AM being told command from RM
Dec 3, 2015
d451181
Removed referring ApplicationAttemptNotFoundException class directly and
Dec 8, 2015
620b33d
Updated with the review comments.
Dec 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,14 @@ private[spark] class ApplicationMaster(
case i: InterruptedException =>
case e: Throwable => {
failureCount += 1
if (!NonFatal(e) || failureCount >= reporterMaxFailures) {
// this exception was introduced in hadoop 2.4 and this code would not compile
// with earlier versions if we refer it directly.
if ("org.apache.hadoop.yarn.exceptions.ApplicationAttemptNotFoundException" ==
e.getClass().getName()) {
logError("Exception from Reporter thread.", e)
finish(FinalApplicationStatus.FAILED, ApplicationMaster.EXIT_REPORTER_FAILURE,
e.getMessage)
} else if (!NonFatal(e) || failureCount >= reporterMaxFailures) {
Copy link
Contributor

@andrewor14 andrewor14 Dec 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty confused about this: @tgravescs @vanzin shouldn't we do this only for NonFatal exceptions? For fatal ones we shouldn't even bother catching it.

Copy link
Author

@devaraj-kavali devaraj-kavali Dec 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the exception is fatal then it would finish the application master immediately without continuing retries, otherwise it will retry with the allocate. I think throwing the fatal exception without catching or finishing the application master on fatal exception wouldn’t make big difference here.

finish(FinalApplicationStatus.FAILED,
ApplicationMaster.EXIT_REPORTER_FAILURE, "Exception was thrown " +
s"$failureCount time(s) from Reporter thread.")
Expand Down