Skip to content

SPARK-12105 - SPARK-SQL add convenient show functions #10130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbonofre wants to merge 3 commits into from
Closed

SPARK-12105 - SPARK-SQL add convenient show functions #10130

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27bd244
SPARK-12105 - SPARK-SQL add convenient show functions
jbonofre Dec 3, 2015
381dfd0
SPARK-12105 - Remove clunky functions and add showString() alias func…
jbonofre Dec 11, 2015
694e94f
SPARK-12105 - Cleanup import, copy comment, and use truncate default …
jbonofre Dec 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,12 +160,19 @@ class DataFrame private[sql](
}
}

/**
* Compose the string representing rows for output
*/
def showString(): String = {
showString(20);
Copy link
Contributor

@andrewor14 andrewor14 Dec 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove ;, this is scala. I'll fix this on merge

}

/**
* Compose the string representing rows for output
* @param _numRows Number of rows to show
* @param truncate Whether truncate long strings and align cells right
*/
private[sql] def showString(_numRows: Int, truncate: Boolean = true): String = {
def showString(_numRows: Int, truncate: Boolean = true): String = {
val numRows = _numRows.max(0)
Copy link
Contributor

@andrewor14 andrewor14 Dec 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another minor thing: now that this is a public API we should expose a better parameter name

def showString(numRows: Int, ...): String = {
  val _numRows = numRows.max(0)
}

Copy link
Contributor

@dilipbiswal dilipbiswal Dec 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewor14 Do we need similar change for dataset api ?

Copy link
Contributor

@andrewor14 andrewor14 Dec 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do that separately

Copy link
Contributor

@dilipbiswal dilipbiswal Dec 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewor14 Thanks Andrew.

val sb = new StringBuilder
val takeResult = take(numRows + 1)
Expand Down