Skip to content

[SPARK-12187] *MemoryPool classes should not be fully public #10182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewor14 wants to merge 2 commits into from
Closed

[SPARK-12187] *MemoryPool classes should not be fully public #10182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dab71d8
Tighten visibility on *MemoryPool classes
Dec 8, 2015
c0e16ad
Remove unnecessary private val
Dec 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/memory/ExecutionMemoryPool.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ import org.apache.spark.Logging
* @param lock a [[MemoryManager]] instance to synchronize on
* @param poolName a human-readable name for this pool, for use in log messages
*/
class ExecutionMemoryPool(
private[memory] class ExecutionMemoryPool(
lock: Object,
poolName: String
) extends MemoryPool(lock) with Logging {
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/memory/MemoryPool.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import javax.annotation.concurrent.GuardedBy
* to `Object` to avoid programming errors, since this object should only be used for
* synchronization purposes.
*/
abstract class MemoryPool(lock: Object) {
private[memory] abstract class MemoryPool(lock: Object) {

@GuardedBy("lock")
private[this] var _poolSize: Long = 0
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/memory/StorageMemoryPool.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import org.apache.spark.storage.{MemoryStore, BlockStatus, BlockId}
*
* @param lock a [[MemoryManager]] instance to synchronize on
*/
class StorageMemoryPool(lock: Object) extends MemoryPool(lock) with Logging {
private[memory] class StorageMemoryPool(lock: Object) extends MemoryPool(lock) with Logging {

@GuardedBy("lock")
private[this] var _memoryUsed: Long = 0L
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/memory/UnifiedMemoryManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ import org.apache.spark.storage.{BlockStatus, BlockId}
private[spark] class UnifiedMemoryManager private[memory] (
conf: SparkConf,
val maxMemory: Long,
private val storageRegionSize: Long,
storageRegionSize: Long,
numCores: Int)
extends MemoryManager(
conf,
Expand Down