-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-12548][Build] Add more exceptions to Guava relocation #10442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ation , So far, all guava 14.0.1 Optional Class dependencies have added;
|
Can one of the admins verify this patch? |
…ake-distribution.sh .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these changes you've made can't be merged. Do you mind closing this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes only used by myself, don't need merge. But I hope the following changes be merged:
Add com.google.common.base.AbstractIterator exceptions to Guava relocation , So far, all guava 14.0.1 Optional Class dependencies have added;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, as I say, there's no way this PR can be merged like this anyway, so please close it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
|
Why does this need to be added? |
|
@srowen Exception in thread "main" java.lang.IllegalAccessError: class com.google.common.base.Optional$1$1 cannot access its superclass org.spark-project.guava.base.AbstractIterator
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at com.google.common.base.Optional$1.iterator(Optional.java:223)
at com.google.common.collect.ImmutableSet.copyOf(ImmutableSet.java:300)
at com.facebook.swift.codec.metadata.AbstractThriftMetadataBuilder.inferThriftFieldIds(AbstractThriftMetadataBuilder.java:566)
at com.facebook.swift.codec.metadata.AbstractThriftMetadataBuilder.inferThriftFieldIds(AbstractThriftMetadataBuilder.java:542)
at com.facebook.swift.codec.metadata.AbstractThriftMetadataBuilder.normalizeThriftFields(AbstractThriftMetadataBuilder.java:483)
at com.facebook.swift.codec.metadata.ThriftStructMetadataBuilder.<init>(ThriftStructMetadataBuilder.java:48)
at com.facebook.swift.codec.metadata.ThriftCatalog.extractThriftStructMetadata(ThriftCatalog.java:542)
at com.facebook.swift.codec.metadata.ThriftCatalog.getThriftStructMetadata(ThriftCatalog.java:408)
at com.facebook.swift.codec.metadata.ThriftCatalog.getThriftTypeUncached(ThriftCatalog.java:283)
at com.facebook.swift.codec.metadata.ThriftCatalog.getThriftType(ThriftCatalog.java:215)
at com.facebook.swift.service.metadata.ThriftMethodMetadata.<init>(ThriftMethodMetadata.java:90)
at com.facebook.swift.service.metadata.ThriftServiceMetadata.<init>(ThriftServiceMetadata.java:73)
at com.facebook.swift.service.ThriftServiceProcessor.<init>(ThriftServiceProcessor.java:76)
at com.facebook.swift.service.ThriftServiceProcessor.<init>(ThriftServiceProcessor.java:65) |
|
@microhello please file a JIRA and add it to the title of this PR. See how other patches are opened. |
|
@andrewor14 I have created a issue: https://issues.apache.org/jira/browse/SPARK-12548 |
|
Yeah the issue here is that this is already a "duplicate" of the issue to remove the Guava exceptions anyway |
|
Also, I just noticed this is opened against the wrong branch. Please close this PR and re-open it against master if we do decide to continue work on this issue. |
Add
com.google.common.base.AbstractIteratorexceptions to Guava relocation , So far, all guava 14.0.1OptionalClass dependencies have added;