[SPARK-12340][SQL]fix Int overflow in the SparkPlan.executeTake, RDD.take and AsyncRDDActions.takeAsync #10487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #2256 has finished for PR 10487 at commit
|
Member
|
LGTM |
Member
|
@QiangCai LGTM but could you add test cases? |
Contributor
Author
|
@sarutak I will try to add test cases. |
Contributor
Author
|
When I am rebasing from master, I get many conflicts. I don't known how to resolve it. I have just pushed the commit "merge". |
Member
|
@QiangCai the merge commit is wrong as you can see. You can revert it, commit, rebase from master, fix conflicts, and force-push a merge to fix. Or, if you're not sure how to do it, close this PR and open a new one. |
Contributor
Author
|
I have created another pull request #10562. |
asfgit
pushed a commit
that referenced
this pull request
Jan 6, 2016
….take and AsyncRDDActions.takeAsync I have closed pull request #10487. And I create this pull request to resolve the problem. spark jira https://issues.apache.org/jira/browse/SPARK-12340 Author: QiangCai <david.caiq@gmail.com> Closes #10562 from QiangCai/bugfix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@srowen I new this pull request to to resolve the problem.
another pull request
#10310
jira
https://issues.apache.org/jira/browse/SPARK-12340