[SPARK-4819] Remove Guava's "Optional" from public API - WIP #10512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @srowen -- if we use Scala's Option, I think we can just recommend users to use get and isDefined. |
Member
|
Yes that's viable too. I was just prepping something very similar but with an inlined clone of Java 8 Optional, on the theory that's next-most-Java-like. #10513 |
|
Test build #48426 has finished for PR 10512 at commit
|
Contributor
Author
|
Going to close this one since I was only posting it for demo. |
asfgit
pushed a commit
that referenced
this pull request
Jan 8, 2016
Replace Guava `Optional` with (an API clone of) Java 8 `java.util.Optional` (edit: and a clone of Guava `Optional`) See also #10512 Author: Sean Owen <sowen@cloudera.com> Closes #10513 from srowen/SPARK-4819.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an example to use Scala Option to replace Guava Optional. I'm actually not sure whether this is the best option since it breaks source compatibility beyond "import".