Skip to content

Conversation

@vanzin
Copy link
Contributor

@vanzin vanzin commented Jan 6, 2016

Turn import ordering violations into build errors, plus a few adjustments
to account for how the checker behaves. I'm a little on the fence about
whether the existing code is right, but it's easier to appease the checker
than to discuss what's the more correct order here.

Plus a few fixes to imports that cropped in since my recent cleanups.

Turn import ordering violations into build errors, plus a few adjustments
to account for how the checker behaves. I'm a little on the fence about
whether the existing code is right, but it's easier to appease the checker
than to discuss what's the more correct order here.

Plus a few fixes to imports that cropped in since my recent cleanups.
@vanzin
Copy link
Contributor Author

vanzin commented Jan 6, 2016

I'll let this simmer for a few days to wait for new PRs that might have violations to go in, and fix those... but at some point I'll get bored of fixing things and probably push this.

@SparkQA
Copy link

SparkQA commented Jan 6, 2016

Test build #48816 has finished for PR 10612 at commit 1f08d6e.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor Author

vanzin commented Jan 6, 2016

retest this please

@SparkQA
Copy link

SparkQA commented Jan 6, 2016

Test build #48834 has finished for PR 10612 at commit 930ccd3.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 6, 2016

Test build #48862 has finished for PR 10612 at commit 35569f9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'd need to remove this line

@SparkQA
Copy link

SparkQA commented Jan 7, 2016

Test build #48888 has finished for PR 10612 at commit 6da306d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jan 7, 2016

LGTM.

@rxin
Copy link
Contributor

rxin commented Jan 7, 2016

You should probably just find a slow day (Sat night / Sun morning?) to bring this up to date and merge it.

@vanzin
Copy link
Contributor Author

vanzin commented Jan 7, 2016

Will probably do that Monday morning (or Sunday evening if I'm feeling bored).

@SparkQA
Copy link

SparkQA commented Jan 11, 2016

Test build #49077 has finished for PR 10612 at commit 782f6de.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 11, 2016

Test build #49081 has finished for PR 10612 at commit 2226c9d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jan 11, 2016

I've merged this. Thanks.

@asfgit asfgit closed this in 6439a82 Jan 11, 2016
@vanzin vanzin deleted the SPARK-3873-enable branch January 11, 2016 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants