[SPARK-12577][SQL] Better support of parentheses in partition by and order by clause of window function's over clause

[viirya]

JIRA: https://issues.apache.org/jira/browse/SPARK-12577

[hvanhovell]

@viirya what is the reason for breaking up the identifiers_parser.g? Shall we - at least - wait with doing until #10583 is in, and do this in a separate ticket?

[hvanhovell]

@viirya what line(s) did you change? It is quite hard to see what has changed.

[viirya]

@hvanhovell I just modified precedenceUnarySuffixExpression. But the generated java file will have "code too large" error. So I need to split it to two files.

[viirya]

@hvanhovell I made the change here.

[viirya]

@hvanhovell I am ok to wait until #10583 is in. If you are asking to split identifiers_parser.g to two parts in a separate ticket, I am also ok for that. And doing that should make the change in this PR more clearer. Then this one can wait for it too.

[hvanhovell]

@viirya thanks. Could you also explain why you feel that we need to split up the grammar?

[SparkQA]

Test build #48861 has finished for PR 10620 at commit ae1aa8a.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[hvanhovell]

@viirya I missed your comment on splitting the file. That makes perfect sense.

@davies code too large error viirya is hitting, looks similar to the problems you are having in #10622.

[davies]

@viirya Since you need to rebase this PR, I will help to create a PR only for splitting IdentifiersParser.g, #10624

[viirya]

@davies thanks and I saw that pr was merged. I will rebase this pr later.

[SparkQA]

Test build #48929 has finished for PR 10620 at commit d0511c0.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[hvanhovell]

LGTM

[davies]

Does this support (a is null) ?

[viirya]

Yes. I think so.

[SparkQA]

Test build #49037 has finished for PR 10620 at commit 119a055.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[davies]

LGTM, merging into master, thanks!