[SPARK-4628][BUILD] Remove all non-Maven-Central repositories from build #10659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There was a problem hiding this comment.
The MQTT artifact was the one which prompted the creation of https://issues.apache.org/jira/browse/SPARK-4628 in the first place. This newer version is published to Maven Central and has no external dependencies.
@pwendell, interestingly enough this change does not cause dev/deps checks to fail because external/ projects aren't tracked there.
JoshRosen
changed the title
|
Test build #49006 has finished for PR 10659 at commit
|
Contributor
Author
|
Jenkins, retest this please. |
|
Test build #49029 has finished for PR 10659 at commit
|
Contributor
|
Looks great. I'm going to merge this. |
asfgit
pushed a commit
that referenced
this pull request
Jan 11, 2016
#10659 removed the repository `https://repo.eclipse.org/content/repositories/paho-releases` but it's needed by MiMa because `spark-streaming-mqtt(1.6.0)` depends on `mqttv3(1.0.1)` and it is provided by the removed repository and maven-central provide only `mqttv3(1.0.2)` for now. Otherwise, if `mqttv3(1.0.1)` is absent from the local repository, dev/mima should fail. JoshRosen Do you have any other better idea? Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp> Closes #10688 from sarutak/SPARK-4628-followup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes all non-Maven-central repositories from Spark's build, thereby avoiding any risk of future build-breaks due to us accidentally depending on an artifact which is not present in an immutable public Maven repository.
I tested this by running
inside of a fresh Ubuntu Docker container with no Ivy or Maven caches (I did a similar test for SBT).