Skip to content

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Jan 9, 2016

No description provided.

@rxin
Copy link
Contributor Author

rxin commented Jan 9, 2016

This should be merged together with amplab/spark-ec2#21

@SparkQA
Copy link

SparkQA commented Jan 9, 2016

Test build #49043 has finished for PR 10673 at commit 3228f07.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jan 9, 2016

+1

@nchammas
Copy link
Contributor

nchammas commented Jan 9, 2016

There was once talk of leaving the spark-ec2 executable in here and just downloading the script from the AMPLab repo on execution. That way users can continue to use the script as though it lived in the Spark repo.

Are we not doing that anymore? It's fine with me either way; I'm just checking.

@JoshRosen
Copy link
Contributor

Given the scope of other deprecations / changes in Spark 2.0, I personally think that it's okay to leave out the wrapper script which forwards to the new repo. Note that I would support the wrapper / forwarder script if this change was targeted at a 1.x release, but for 2.x I think it's okay to just make this change and add migration instructions in the release notes.

@nchammas
Copy link
Contributor

nchammas commented Jan 9, 2016

Sounds fine with me and I agree with your position. 👍

I hope this makes it easier for people to contribute to spark-ec2.

@rxin
Copy link
Contributor Author

rxin commented Jan 10, 2016

@shivaram I'm going to merge this one first. Let me know if there is a problem with the move. I can easily revert this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants