Skip to content

[SPARK-12736][CORE][DEPLOY] Standalone Master cannot be started due t… #10674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaceklaskowski wants to merge 1 commit into from
Closed

[SPARK-12736][CORE][DEPLOY] Standalone Master cannot be started due t… #10674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions network/common/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<scope>compile</scope>
Copy link
Contributor

@JoshRosen JoshRosen Jan 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't compile the default scope? i.e. couldn't you leave out the explicit compile scope here and just not specify a scope?

Copy link
Contributor Author

@jaceklaskowski jaceklaskowski Jan 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought so, but the line has fixed standalone Master to start (after the line got removed in 659fd9d).

Copy link
Member

@zsxwing zsxwing Jan 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't compile the default scope? i.e. couldn't you leave out the explicit compile scope here and just not specify a scope?

It's set to provided in the parent pom.xml:

spark/pom.xml

Line 365 in b23c452

<groupId>com.google.guava</groupId>

Copy link
Contributor

@JoshRosen JoshRosen Jan 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, gotcha; (this is why I shouldn't review before morning coffee).

</dependency>

<!-- Test dependencies -->
Expand Down