-
Notifications
You must be signed in to change notification settings - Fork 29k
[WIP] [SPARK-12177] [STREAMING] Update KafkaDStreams to new Kafka 0.9 Consu… #10681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
+1 |
|
Nikita, since we are still working on this, could you please mark this PR as [WIP] in the title so no one gets confused? Thanks! |
Getting rid of an extra dependency
More changes
|
Hi @nikit-os, I have made a bunch of more changes in my personal branch at https://github.com/markgrover/spark/tree/kafka09-integration and some WIP changes for the python implementation at https://github.com/markgrover/spark/tree/kafka09-integration-python. For now, I want to drive forward the Java/Scala and get feedback from the community. To make that easier, I would love to file a separate pull request that will be based off your original PR (i.e. this pull request). My desire is not take credit away from you, in fact, I will keep the history in tact, and explicitly mention that you have contributed a good chunk of this work but I don't want the logistical overhead of having to issue you a pull request to your branch, every time I want to update this pull request. Would it be ok if I create a new pull request, that's a super set of, and supersedes this pull request? |
|
Hi, @markgrover! Yes, I am not against new PR and closing this. Thank you! |
…mer API